Conversation
This comment has been minimized.
This comment has been minimized.
ryux1
force-pushed
the
ryux1/rasterio-rowcol-op-return
branch
from
September 6, 2026 04:27
364da14 to
afdb012
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
I don't think all the extra Use and for the existing
You can remove all the extra overloads. This should address the issue. |
Contributor
There was a problem hiding this comment.
No need to include tests
Contributor
Author
|
Updated to use a defaulted type variable and removed the extra overloads as suggested. I also applied the same simplification to |
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16342.
Preserve the default integer result while propagating a custom operation's return type through
rowcolandindex.Agent used: OpenAI Codex.