Draft
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: setuptools (https://github.com/pypa/setuptools)
+ setuptools/command/build_ext.py:226: error: Argument "compiler" to "new_compiler" has incompatible type "Compiler | str | None"; expected "str | None" [arg-type]
+ setuptools/command/build_clib.py:77: error: Item "str" of "Compiler | str | None" has no attribute "object_filenames" [union-attr]
+ setuptools/command/build_clib.py:77: error: Item "None" of "Compiler | str | None" has no attribute "object_filenames" [union-attr]
+ setuptools/command/build_clib.py:89: error: Item "str" of "Compiler | str | None" has no attribute "compile" [union-attr]
+ setuptools/command/build_clib.py:89: error: Item "None" of "Compiler | str | None" has no attribute "compile" [union-attr]
+ setuptools/command/build_clib.py:101: error: Item "str" of "Compiler | str | None" has no attribute "create_static_lib" [union-attr]
+ setuptools/command/build_clib.py:101: error: Item "None" of "Compiler | str | None" has no attribute "create_static_lib" [union-attr]
|
Collaborator
Author
|
So this is an issue for setuptools itself... I might be able to push for upstream changes, but I'm not yet sure how to do so in a backwards compatible way. Maybe I'll have to keep these as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
compilerattr in commands is weird, it's never set infinalize_options, but rather inruninstead. (normally we treat anything infinalize_optionsin setuptools the same as if it's been initialized in__init__)With downstream command subclasses also intended to override
finalize_options, this meanscompilermay not be an actualCompilerclass instance yet.Tentatively opening to see ecosystem check.
This would, once again, benefit from
AnyOf: python/typing#566