Skip to content

update GDB stubs to 16.3 #13923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update GDB stubs to 16.3 #13923

wants to merge 2 commits into from

Conversation

oltolm
Copy link

@oltolm oltolm commented May 2, 2025

No description provided.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@srittau
Copy link
Collaborator

srittau commented May 5, 2025

Thanks! stubs/gdb/METADATA.toml needs to be updated to the correct version as well. Also, for review purposes, is there some way to view the changes to the Python API between the versions?

@oltolm
Copy link
Author

oltolm commented May 10, 2025

You can look at NEWS and search for * Python API.

This comment has been minimized.

Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

pwndbg (https://github.com/pwndbg/pwndbg)
+ pwndbg/dbg/gdb/symbol.py:162: error: Unused "type: ignore" comment  [unused-ignore]

srittau
srittau previously approved these changes May 30, 2025
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks reasonable and I trust you and stubtest here.

@srittau srittau dismissed their stale review May 30, 2025 14:41

Well, I trust stubtest, but that complains.

@srittau
Copy link
Collaborator

srittau commented May 30, 2025

@oltolm Our CI still complains about a few symbols that are not available at runtime: https://github.com/python/typeshed/actions/runs/15323229467/job/43111418230?pr=13923

Are you sure these items exist in gdb 16.3? In that case, these items need to be added to stubs/gdb/@tests/stubtest_allowlist.txt, otherwise they need to be removed from the stubs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants