Improve docker.types

[donbarbos]

No description provided.

[Avasam]

I didn't comment it on every instance, but the annoying thing with using list and dict as parameter types, is that they're invariant. Meaning unions have to be exact.
A list[str] cannot be passed to a list[str | int] parameter !

So everywhere you have a union like dict[str, Foo | Bar], you need to expand it to accept all possible permutations:
dict[str, Foo] | dict[str, Bar] | dict[str, Foo | Bar] (same with lists)

That's why, even though some methods not explicitly requiring a list or dict may be an implementation detail, I instead recommended some covariant types like Iterable and Mapping where possible.

[donbarbos]

Looks done 👍
I used Iterable as you suggested, but I wanted to ask what you think about using Sequence, it seems to be a more strict and more suitable for list parameters

[Avasam]

I used Iterable as you suggested, but I wanted to ask what you think about using Sequence, it seems to be a more strict and more suitable for list parameters

Hmm... I'm not hard set on either. Iterable/Container is exact to the actual implementation, but it also looks like an implementation detail that we can get away with non-lists in those cases, so maybe it's "safer" for the users to use a Sequence.

This is also something we can ask about upstream to get some clarification.

My personal preference is to follow the implementation, and update it in a version bump PR if it changes. But I won't block on either.

[Avasam]

Using GitHub comments was a bit too complex to list the rest of the invariance issues, so I opened donbarbos#1 against your PR branch.

[donbarbos]

Big thank to you. In the future I'll try to be more careful with invariant types

[github-actions]

Diff from mypy_primer, showing the effect of this PR on open source code:

dragonchain (https://github.com/dragonchain/dragonchain)
- dragonchain/job_processor/contract_job.py:251:16: error: Module has no attribute "errors"  [attr-defined]
- dragonchain/job_processor/contract_job.py:268:17: error: Module has no attribute "errors"  [attr-defined]
- dragonchain/job_processor/contract_job.py:280:16: error: Module has no attribute "errors"  [attr-defined]

[donbarbos]

@Avasam if you want i can split this PR into several (like "Improve docker.api|models|types|utils")

[Avasam]

@donbarbos No worries! I was just giving this a week in case other maintainers wanted to take a look or had objections, then forgot. I'll merge, thanks for the ping.