Enable Ruff groups we already pass#13751
Merged
srittau merged 2 commits intopython:mainfrom Apr 2, 2025
Merged
Conversation
srittau
approved these changes
Apr 1, 2025
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
I'm fine with these for now. We can always disable rules later if they turn out to be bothersome.
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #13295
What's left are groups for which we already pass all the rules. And that I didn't already identify as "doesn't concern us". Please consider based on the documented rules. And your own experience if you've used those rules in a different project. If a group is more controversial, I'll split it off to a different PR.
Rules: