Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Ruff flake8-builtins (A) #13729

Merged
merged 1 commit into from
Mar 28, 2025
Merged

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Mar 27, 2025

Ref #13295
flake8-builtins (A)

At that point, it' easier and more concise to disable the entire group in stubs.

So this group would only apply to our tests/scripts.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a meh rule, in my opinion, considering that Python built-ins block quite a few important names (filter, id, dir), but I don't mind.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a bit pedantic for sure, but this one seems reasonable to me. The recommendations from this rule are never going to tell you to do something that's actually incorrect, unlike e.g. #13728 (where the more correct thing arguably does sometimes contradict the rule's recommendation)

@AlexWaygood AlexWaygood merged commit 83ee2a2 into python:main Mar 28, 2025
58 checks passed
@Avasam Avasam deleted the flake8-builtins-(A) branch March 28, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants