Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pathlib.PurePath.__eq__ #10662

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Remove pathlib.PurePath.__eq__ #10662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d48d4e9
Remove pathlib.PurePath.__eq__
hauntsaninja Sep 4, 2023
7cf01aa
.
hauntsaninja Sep 4, 2023
c94c946
Apply suggestions from code review
hauntsaninja Sep 5, 2023
c97353c
alex example
hauntsaninja Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion stdlib/pathlib.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ class PurePath(PathLike[str]):
def __new__(cls, *args: StrPath) -> Self: ...

def __hash__(self) -> int: ...
def __eq__(self, other: object) -> bool: ...
def __fspath__(self) -> str: ...
def __lt__(self, other: PurePath) -> bool: ...
def __le__(self, other: PurePath) -> bool: ...
Expand Down
20 changes: 20 additions & 0 deletions test_cases/stdlib/check_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
from __future__ import annotations

from pathlib import Path, PureWindowsPath

if Path("asdf") == Path("asdf"):
...

# https://github.com/python/typeshed/issues/10661
# Provide a true positive error when comparing Path to str
# mypy should report a comparison-overlap error with --strict-equality,
# and pyright should report a reportUnnecessaryComparison error
if Path("asdf") == "asdf": # type: ignore
...

# Errors on comparison here are technically false positives. However, this comparison is a little
# interesting: it can never hold true on Posix, but could hold true on Windows. We should experiment
# with more accurate __new__, such that we only get an error for such comparisons on platforms
# where they can never hold true.
if PureWindowsPath("asdf") == Path("asdf"): # type: ignore
...