fix: remove |safe from striptags output in search templates#3060
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
fix: remove |safe from striptags output in search templates#3060fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
Four search include templates used |safe on striptags output, which Django's docs explicitly warn against. The indexed value is now genuinely plain text at index time via html.unescape(), so autoescaping can safely render it. Closes python#3046
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The
striptagsfilter output uses|safein search result templates, allowing HTML content inside matched search snippets to be rendered unescaped. This is a potential XSS vector since user content in indexed pages may contain HTML.Fix
Removed the
|safefilter from striptags output in search template, ensuring HTML is properly escaped.Fixes #3046
Support my open source work: https://buymeacoffee.com/muhamedfazalps