Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix different linkage error with cp313-win #136

Closed
wants to merge 1 commit into from

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Jan 28, 2025

Seems there was one another regression. Our the cp313-win wheel build started to fail after the pythoncapi_compat.h update was merged. We don't test every platform version combination in CI, that's why I missed it initially.

  C:/hostedtoolcache/windows/Python/3.13.1/x64/include/internal/pycore_pystate.h(271): error C2375: '_Py_GetConfig': redefinition; different linkage (diff)
  D:/a/mypy/mypy/mypyc/lib-rt/pythoncapi_compat.h(2112): note: see declaration of '_Py_GetConfig' (diff)

Seems like a similar issue to #115 where MSVC requires that the signatures match the upstream ones exactly.

Also updated _Py_fopen_obj even though that didn't fail for us. Probably just because we don't use Py_fopen yet.

@cdce8p
Copy link
Contributor Author

cdce8p commented Jan 28, 2025

/CC @vstinner

@vstinner
Copy link
Member

This issue should be fixed by the change c84545f : can you please try the fix in mypy CI?

@cdce8p cdce8p deleted the fix-win branch January 28, 2025 13:36
@cdce8p
Copy link
Contributor Author

cdce8p commented Jan 28, 2025

This issue should be fixed by the change c84545f : can you please try the fix in mypy CI?

Thanks! My test setup looks fine. Opened python/mypy#18560 for mypy.
The full CI run is only triggered after merge, but I expect it to be good as well.

@vstinner
Copy link
Member

Oh! I misread this pull request. I saw it as an issue and I wrote exactly the same fix :-D Sorry, I could merge your PR directly.

@cdce8p
Copy link
Contributor Author

cdce8p commented Jan 28, 2025

can you please try the fix in mypy CI?

It's fixed now. https://github.com/mypyc/mypy_mypyc-wheels/actions/runs/13014956712/job/36301735749

@vstinner
Copy link
Member

Thabks again for your bug report and your fix @cdce8p!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants