Fix different linkage error with cp313-win #136
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems there was one another regression. Our the
cp313-win
wheel build started to fail after thepythoncapi_compat.h
update was merged. We don't test every platform version combination in CI, that's why I missed it initially.Seems like a similar issue to #115 where MSVC requires that the signatures match the upstream ones exactly.
Also updated
_Py_fopen_obj
even though that didn't fail for us. Probably just because we don't usePy_fopen
yet.