Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontally align the collapse button icon #219

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Feb 2, 2025

Just something that was bugging me a bit :D I hope this won't be an issue regarding 4.x compatibility?

Before
image

After
image


📚 Documentation preview 📚: https://python-docs-theme-previews--219.org.readthedocs.build/

@m-aciek
Copy link
Contributor

m-aciek commented Feb 2, 2025

It may be worth checking how this affect Sphinx 4-, as Python 3.10 and 3.9 use Sphinx 3.4.3.

/* after Sphinx 4.x and earlier is dropped, only the below is needed */
width: 12px;
border-radius: 0 5px 5px 0;
border-left: none;
}

#sidebarbutton span {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we achieve compatibility without deleting this?

@AA-Turner
Copy link
Member

It may be worth checking how this affect Sphinx 4-, as Python 3.10 and 3.9 use Sphinx 3.4.3.

Note I'm proposing pinning python-docs-theme for the 3.10 and 3.11 branches in python/cpython#129576. We already pinned for the 3.8 and 3.9 branches in python/cpython#115349. However in the absence of that, this PR should be tested with 3.4.3, 7.2.6, and 8.1.3 ([ref]).

A

@tomasr8
Copy link
Member Author

tomasr8 commented Feb 2, 2025

I'll test it later today or tomorrow (at Fosdem currently)

@tomasr8
Copy link
Member Author

tomasr8 commented Feb 3, 2025

In addition to 8.1.3, I checked with 3.4.3 and 7.2.6 and both work as well :)

@AA-Turner AA-Turner merged commit 2f15ba6 into python:main Feb 3, 2025
15 checks passed
@tomasr8 tomasr8 deleted the center-collapse-btn branch February 3, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants