Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unset default list style #179

Closed
wants to merge 2 commits into from

Conversation

Privat33r-dev
Copy link
Contributor

@Privat33r-dev Privat33r-dev commented Mar 17, 2024

Clean up unnecessary symbols, leading to improvement in the content readability.
Before:
image

After:
image

Preview: https://python-docs-theme-previews--179.org.readthedocs.build/en/179/tutorial/index.html

Before: https://python-docs-theme-previews.readthedocs.io/en/latest/tutorial/index.html

Clean up unnecessary symbols, leading to improvement in the content readability
@hugovk
Copy link
Member

hugovk commented Mar 17, 2024

Please could post example before and after screenshots, with links?

This PR has a preview at https://python-docs-theme-previews--179.org.readthedocs.build/en/179/ (shown in the status checks).

For the before, it's probably best to use https://python-docs-theme-previews.readthedocs.io, which has the recent font change (as the font change hasn't been deployed to https://docs.python.org yet).

Thanks!

@Privat33r-dev
Copy link
Contributor Author

@hugovk thanks for the reminder, I thought about it, but somehow it slipped my mind (after adventure with git, I guess).

@hugovk
Copy link
Member

hugovk commented Mar 17, 2024

Git is the adventure that keeps giving :)

Unfortunately this PR also removes bullets in places like this:

image

https://python-docs-theme-previews.readthedocs.io/en/latest/library/asyncio.html

->

image

https://python-docs-theme-previews--179.org.readthedocs.build/en/179/library/asyncio.html

@Privat33r-dev
Copy link
Contributor Author

Privat33r-dev commented Mar 17, 2024

Frankly, it doesn't work that well in many places, thanks for pointing that out :) I will rethink this approach, maybe I will come back with a better approach later.

Currently it still has problems in places like:
https://python-docs-theme-previews--179.org.readthedocs.build/en/179/glossary.html#term-parameter
etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants