Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce underline offset #166

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 27, 2024

We added underlines in #160, with an offset to make sure they don't obscure underscores in code formatting. With fresh eyes, 0.3em looks a bit too much. Let's reduce it.

0.3em

image

0.2em

image

Copy link
Member

@ezio-melotti ezio-melotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried checking this on a paragraph with lot of dunders?

ISTM that with 0.2em the underline touches the underscores.
Maybe 0.25em would be a good comprise?

@hugovk
Copy link
Member Author

hugovk commented Jan 27, 2024

Here's a link to the build preview of that section:

https://python-docs-theme-previews--166.org.readthedocs.build/en/166/reference/datamodel.html#object.reversed

There is a small gap between the underscore and underline (Android/Chrome):

Screenshot_20240127_182017_Chrome

@hugovk
Copy link
Member Author

hugovk commented Jan 27, 2024

macOS / Chrome:

0.2em

image

0.21em

image

0.22em

image

0.23em

image

0.24em

image

0.25em

image

@ezio-melotti
Copy link
Member

This is on Linux/Firefox:
0.2em:
image

0.25em:
image

0.3em:
image

I like 0.25 -- with 0.2 I have to do a double take because I'm not sure if there are two lines or I'm seeing double; with 0.3 the difference is clear, but it does look a bit too distant (especially when there are no underscores); with 0.25 the underline is closer to the text but I can still see the two lines distinctly. (Disclaimer, I'm running on 4h of sleep and my eyes are a bit tired, I can take a look again tomorrow -- maybe the 0.2 will look better).

@hugovk
Copy link
Member Author

hugovk commented Jan 27, 2024

0.25em looks okay to me, PR updated.

@pradyunsg pradyunsg merged commit ba55891 into python:main Jan 27, 2024
11 checks passed
@hugovk hugovk deleted the text-underline-offset branch January 27, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants