Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show logs on error #164

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Show logs on error #164

merged 1 commit into from
Jan 10, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Jan 10, 2024

Currently the 3.8 and 3.9 branches are failing to build, but no error logs are printed on the CI due to sys.stderr.isatty() being false:

https://github.com/python/docsbuild-scripts/blob/f0a570aec824c7d775ea9d345a89d1b10d0f11b2/build_docs.py#L604-L617

This will show the logs if there's a failure.

@m-aciek
Copy link
Contributor

m-aciek commented Jan 10, 2024

By the way, the PR to fix the upstream: python/cpython#113815.

@AA-Turner AA-Turner merged commit 45793b5 into python:main Jan 10, 2024
9 of 11 checks passed
@hugovk hugovk deleted the view-logs branch January 10, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants