-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 750: Updates after community feedback #4124
Conversation
Next round of updates to PEP 750
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to do a full review of this PR but ran out of time. Here are a few comments I have. In any case, I offer to just merge this PR, so readers of the thread won't have to wonder if their changes are accepted. You can always merge another PR -- there's no particular process to be followed here.
…o pep750-october-updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the reminder to review! Nothing particularly major, though a few questions:
A
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
…o pep750-october-updates
Thanks for all the good catches @AA-Turner -- I think I've addressed all of these. Let me know how things look! |
Co-authored-by: Adam Turner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Are you waiting for any further reviews of this PR, or would you like for it to be merged?
A
Happy to have it merged! Thanks again for all your help. |
Updates include:
Template
, includingstrings
,interpolations
, andvalues
.Template.__hash__()
Template.args
explicitly be atuple
Thanks to @lysnikolaou @koxudaxi @pauleveritt @jimbaker and everyone in recent discussion threads for all the useful feedback.
I opened a new Discourse thread for this updated PR.
📚 Documentation preview 📚: https://pep-previews--4124.org.readthedocs.build/