Fix crash on access to local classes#2855
Merged
Merged
Conversation
Member
Author
|
@gvanrossum If you are curious, this monster still crashes when imported from elsewhere in incremental mode: from typing import NamedTuple
class C:
def f(self) -> None:
class D:
class E:
def g(self) -> None:
A = NamedTuple('A', [('x', int), ('y', int)])
self.a = A(1, 1)
self.c = D.E().aThis is why I made this PR to always use |
Collaborator
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2559
The idea is the same as in PR #2553. The only difference is that mangled names are always stored in
globals, otherwise there would be a problem for a method in a nested class that is itself inside a method.