Allow type parameters reusing the name missing from current module #20081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
A5rocks
reviewed
Oct 17, 2025
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
approved these changes
Oct 19, 2025
There was a problem hiding this comment.
This make sense to me. "Auto-generated" type variables must be always added. I will merge this tomorrow if there are no objections from @JukkaL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18507. Fixes #19526. Fixes #19946 (already closed without reproducer, but star imports may cause such issues,
testPEP695TypeVarNameClashStarImportfails on current master).Even if a type parameter is reusing the name from outer scope, it still cannot be a redefinition, so we can safely store it even in presence of unresolved star imports or variables that do not refer to a type.