stubtest: better checking of runtime args with dunder names #18756
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
I just ran it on the numpy stubs in numpy/numtype, and when I remove the allowlist entry that I mentioned in #15302 (comment), it passes 🎉. I'm not sure if it's relevant here, but if I don't remove that allowlist entry, stubtest doesn't report it as unused. edit: I published the code to https://github.com/numpy/numtype/tree/mypy-18756. To repro, run |
|
Thanks for checking, will look into the unused allowlist thing too... |
hauntsaninja
added a commit
to hauntsaninja/numtype
that referenced
this pull request
Mar 7, 2025
cc @jorenham I was looking into python/mypy#18756 (comment) It looks like the pre-release version of mypy crashes (for some reason related to property changes, will investigate). Crash logs are emitted to stderr and process exits with exit code 2. This code does correctly chain the exit code, but swallows stderr.
jorenham
pushed a commit
to numpy/numtype
that referenced
this pull request
Mar 7, 2025
cc @jorenham I was looking into python/mypy#18756 (comment) It looks like the pre-release version of mypy crashes (for some reason related to property changes, will investigate). Crash logs are emitted to stderr and process exits with exit code 2. This code does correctly chain the exit code, but swallows stderr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15302, fixes #14560. Linking #18343