-
-
Notifications
You must be signed in to change notification settings - Fork 91
Adopt "more sound" type annotations #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abravalheri
wants to merge
6
commits into
python:main
Choose a base branch
from
abravalheri:issue-486
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3a90a8d
Use more realistic return types
abravalheri c1612ec
Use type check guard for legacy annotations
abravalheri e30d8f7
Fix type annotation for Python 3.10+
abravalheri 2044db1
Fix warnings in sphinx docs
abravalheri 4fe96a4
Move code specific to backport to compat module
abravalheri c86976d
Workaround sphinx limitations
abravalheri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
""" | ||
Compatibility layer with stdlib. | ||
Only needed when distributing via PyPI/3rd-party package. | ||
""" | ||
|
||
import sys | ||
from typing import TYPE_CHECKING, List, Union | ||
|
||
if TYPE_CHECKING: | ||
# Avoid circular imports | ||
|
||
from importlib import metadata as _legacy | ||
|
||
from typing_extensions import TypeAlias | ||
|
||
from .. import Distribution, PackagePath, _meta | ||
|
||
if sys.version_info >= (3, 10): | ||
from importlib.metadata import PackageMetadata as _legacy_Metadata | ||
else: | ||
from email.message import Message as _legacy_Metadata | ||
|
||
_PackageMetadataOrLegacy: TypeAlias = Union[_legacy_Metadata, _meta.PackageMetadata] | ||
jaraco marked this conversation as resolved.
Show resolved
Hide resolved
|
||
_DistributionOrLegacy: TypeAlias = Union[_legacy.Distribution, Distribution] | ||
_List_PackagePathOrLegacy: TypeAlias = Union[ | ||
List[_legacy.PackagePath], List[PackagePath] | ||
] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.