Skip to content

move environment vars to a configuration file #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions build_docs.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,26 @@
Without any arguments builds docs for all active versions and
languages.

Environment variables for:

- `SENTRY_DSN` (Error reporting)
- `FASTLY_SERVICE_ID` / `FASTLY_TOKEN` (CDN purges)
- `PYTHON_DOCS_ENABLE_ANALYTICS` (Enable Plausible for online docs)

are read from the site configuration path for your platform
(/etc/xdg/docsbuild-scripts on linux) if available,
and can be overriden by writing a file to the user config dir
for your platform ($HOME/.config/docsbuild-scripts on linux).
The contents of the file is parsed as toml:

```toml
[env]
SENTRY_DSN = "https://[email protected]/69420"
FASTLY_SERVICE_ID = "deadbeefdeadbeefdead"
FASTLY_TOKEN = "secureme!"
PYTHON_DOCS_ENABLE_ANALYTICS = "1"
```

Languages are stored in `config.toml` while versions are discovered
from the devguide.

Expand Down Expand Up @@ -48,6 +68,7 @@
import tomlkit
import urllib3
import zc.lockfile
from platformdirs import user_config_path, site_config_path

TYPE_CHECKING = False
if TYPE_CHECKING:
Expand Down Expand Up @@ -906,6 +927,7 @@
"""Script entry point."""
args = parse_args()
setup_logging(args.log_directory, args.select_output)
load_environment_variables()

Check warning on line 930 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L930

Added line #L930 was not covered by tests

if args.select_output is None:
build_docs_with_lock(args, "build_docs.lock")
Expand Down Expand Up @@ -1022,6 +1044,31 @@
logging.getLogger().setLevel(logging.DEBUG)


def load_environment_variables() -> None:
_user_config_path = user_config_path("docsbuild-scripts")
_site_config_path = site_config_path("docsbuild-scripts")
if _user_config_path.is_file():
ENV_CONF_FILE = _user_config_path
elif _site_config_path.is_file():
ENV_CONF_FILE = _site_config_path

Check warning on line 1053 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L1048-L1053

Added lines #L1048 - L1053 were not covered by tests
else:
logging.info(

Check warning on line 1055 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L1055

Added line #L1055 was not covered by tests
"No environment variables configured. "
f"Configure in {_site_config_path} or {_user_config_path}."
)
return

Check warning on line 1059 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L1059

Added line #L1059 was not covered by tests

logging.info(f"Reading environment variables from {ENV_CONF_FILE}.")
if ENV_CONF_FILE == _site_config_path:
logging.info(f"You can override settings in {_user_config_path}.")
elif _site_config_path.is_file():
logging.info(f"Overriding {_site_config_path}.")
with open(ENV_CONF_FILE, "r") as f:
for key, value in tomlkit.parse(f.read()).get("env", {}).items():
logging.debug(f"Setting {key} in environment.")
os.environ[key] = value

Check warning on line 1069 in build_docs.py

View check run for this annotation

Codecov / codecov/patch

build_docs.py#L1061-L1069

Added lines #L1061 - L1069 were not covered by tests


def build_docs_with_lock(args: argparse.Namespace, lockfile_name: str) -> int:
try:
lock = zc.lockfile.LockFile(HERE / lockfile_name)
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
jinja2
platformdirs
sentry-sdk>=2
tomlkit>=0.13
urllib3>=2
Expand Down