Add free-threaded to style guide (#1353) #1722
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
Documentation build overview
Show files changed (5 files in total): 📝 5 modified | ➕ 0 added | ➖ 0 deleted
|
hugovk
reviewed
Jan 6, 2026
Co-authored-by: Hugo van Kemenade <[email protected]>
arunkumargururaj07-star
force-pushed
the
fix-no-gil-terminology
branch
from
ab0e75a to
1012e06
Compare
arunkumargururaj07-star
force-pushed
the
fix-no-gil-terminology
branch
from
1012e06 to
b943f69
Compare
| @@ -1,4 +1,4 @@ | |||
| .. _style-guide: | |||
| .. _style-guide: | |||
Member
There was a problem hiding this comment.
Why the unrelated change?
documentation/style-guide.rst
Outdated
|
|
||
| CPU | ||
| Central processing unit. No need to spell out. | ||
| Central processing unit. No need to spell out. |
Member
There was a problem hiding this comment.
Can you revert the unrelated changes?
documentation/style-guide.rst
Outdated
Comment on lines
83
to
85
| The preferred term for the build mode that makes the global interpreter | ||
| lock (GIL) optional (per :pep:`703`). Avoid using "No-GIL" to prevent | ||
| double negatives (for example, "non-no-GIL"). |
Member
There was a problem hiding this comment.
The indentation is incorrect.
documentation/style-guide.rst
Outdated
|
|
||
| free-threaded | ||
| The preferred term for the build mode that makes the global interpreter | ||
| lock (GIL) optional (per :pep:`703`). Avoid using "No-GIL" to prevent |
Member
There was a problem hiding this comment.
Suggested change
| lock (GIL) optional (per :pep:`703`). Avoid using "No-GIL" to prevent | |
| lock (GIL) optional (per :pep:`703`). Avoid using "No-GIL" to avoid |
A little suggestion, "prevent" seems a little odd here.
There was a problem hiding this comment.
@StanFromIreland I've applied all your feedback. The PR has been updated with the fixes.
- Correct CPU indentation to 3 spaces - Correct free-threaded indentation to 3 spaces - Change 'prevent' to 'avoid' as suggested by reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1353
Added 'free-threaded' to the style guide as the preferred term for PEP 703 to avoid double-negatives.