-
-
Notifications
You must be signed in to change notification settings - Fork 841
Updated "Status of Python versions" page #1531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prerelease
phase description LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits.
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
5ed9dbf
to
3f36d68
Compare
Here's the promised cleanup: nedbat#1 |
Full chart | ||
========== | ||
|
||
.. raw:: html | ||
:file: include/release-cycle-all.svg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the page structure a bit confusing, since it has two charts and two tables, with some level of overlapping between them but otherwise no further symmetry:
- first there's the chart with 2.7 + 3.6-3.14
- then there's a table with 3.9-3.14 (supported versions)
- then there's another table with 2.6-2.7 + 3.0-3.8 (unsupported versions)
- then there's the full chart with 2.6-2.7 + 3.0-3.14 (all versions)
In particular:
- Is there a reason why the first chart includes 2.7/3.6-3.8 even though they are unsupported? Perhaps this could become the chart of supported versions only?
- It might be less confusing if both tables were under the same header ("Version support"?), with either a
<caption>
or a colspanning<th>
on top of each table for "supported"/"unsupported" (or even joined together, with the colspanning<th>
s)
This can also be addressed in a separate PR if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This structure is deliberate. It keeps the tables together, and the least-useful info (the full chart) at the end, and a heavy distinction between active and EOL branches.
Perhaps this could become the chart of supported versions only?
When we get tired of telling people that 2.7 is EOL, we set the special_py27
argument to False :)
That'll still show versions that went EOL during an active branch's lifetime. That should (for 3.8+) match the recommended deprecation period per PEP 387.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It keeps the tables together
This is good, since they complement each other -- that's why I suggested putting them in the same subsection too.
the least-useful info (the full chart) at the end, and a heavy distinction between active and EOL branches.
Removing EOL branches from the first chart would make the distinction even clearer IMHO.
When we get tired of telling people that 2.7 is EOL
I don't think we need it in the first chart for that -- the fact that it's not even included should give them a hint, and if that's not enough they can find 2.7 in the table and in the full chart.
I think everything has been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks all!
<!-- bugfix/security blobs need to be split between the two phases. | ||
Draw the rectangle with two path elements instead. | ||
Thanks Claude.ai for the initial conversion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrevert
<!-- bugfix/security blobs need to be split between the two phases. | |
Draw the rectangle with two path elements instead. | |
Thanks Claude.ai for the initial conversion. | |
<!-- Bugfix/security blobs need to be split between the two phases. | |
Draw the rectangle with two path elements instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Claude served its role -- it allowed Ned to get started -- even if its code was messy and basically none of it remains.
Thank you for pushing this through, Ned! |
This includes changes by me and @encukou. Suggestions welcome.
How would you describe the difference between "feature fixes" and "bug fixes"?
📚 Documentation preview 📚: https://cpython-devguide--1531.org.readthedocs.build/versions/