gh-79366: Fix a race condition when removing a logging handler#154528
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-79366: Fix a race condition when removing a logging handler#154528serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
removeHandler() mutated the handler list in place, so if a handler was removed while callHandlers() was iterating the same list, the following handlers could be skipped. Replace the list instead of mutating it. Co-Authored-By: Ben Spiller <11992588+ben-spiller@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
serhiy-storchaka
added
needs backport to 3.13
serhiy-storchaka
added
the
needs backport to 3.15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removeHandler()removed the handler from the list in place. If a handler was removed whilecallHandlers()was iterating over the same list, whether from another thread or from within anemit()call, the following handlers of the same logger could be skipped, so records were not passed to them.removeHandler()now replaces the list with a copy instead of mutating it in place, socallHandlers()always iterates over a consistent list without needing to acquire the lock. Adding a handler already appends to the end, so it cannot cause a handler to be skipped and is left unchanged.🤖 Generated with Claude Code