Skip to content

idle: fix dedent() usage in htest#152256

Merged
terryjreedy merged 1 commit into
python:mainfrom
methane:fix-htest
Jun 26, 2026
Merged

idle: fix dedent() usage in htest#152256
terryjreedy merged 1 commit into
python:mainfrom
methane:fix-htest

Conversation

@methane

@methane methane commented Jun 26, 2026

Copy link
Copy Markdown
Member

In #112642, there was a mistake in the replacement of multiline string concat to textwrap.dedent(), and extra quote characters were mixed in.

This is a minor issue, so it is not necessary to backport.

@methane methane requested a review from terryjreedy as a code owner June 26, 2026 09:00
StanFromIreland
StanFromIreland reviewed Jun 26, 2026
View reviewed changes
Comment thread Lib/idlelib/idle_test/htest.py
@terryjreedy terryjreedy self-assigned this Jun 26, 2026
@terryjreedy terryjreedy added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 26, 2026
@terryjreedy terryjreedy merged commit 74272d4 into python:main Jun 26, 2026
60 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

Thanks @methane for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152342 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 26, 2026
@bedevere-app

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152343 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2026
@bedevere-app

bedevere-app Bot commented Jun 26, 2026

Copy link
Copy Markdown

GH-152344 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 26, 2026
terryjreedy pushed a commit that referenced this pull request Jun 26, 2026
@miss-islington @methane
[3.13] IDLE: fix dedent() usage in htest (GH-152256) (#152344)
fd6562e 
IDLE: fix dedent() usage in htest (GH-152256)

Fix typos: in GH-112642, initial string concatenation quotes were left when switching to textwrap.dedent().
(cherry picked from commit 74272d4)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
terryjreedy pushed a commit that referenced this pull request Jun 26, 2026
@miss-islington @methane
[3.15] IDLE: fix dedent() usage in htest (GH-152256) (#152342)
ba4084f 
IDLE: fix dedent() usage in htest (GH-152256)

Fix typos: in GH-112642, initial string concatenation quotes were left when switching to textwrap.dedent().
(cherry picked from commit 74272d4)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
terryjreedy pushed a commit that referenced this pull request Jun 26, 2026
@miss-islington @methane
[3.14] IDLE: fix dedent() usage in htest (GH-152256) (#152343)
ee1ae1d 
IDLE: fix dedent() usage in htest (GH-152256)

Fix typos: in GH-112642, initial string concatenation quotes were left when switching to textwrap.dedent().
(cherry picked from commit 74272d4)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@terryjreedy

terryjreedy commented Jun 26, 2026

Copy link
Copy Markdown
Member

Backports merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

@terryjreedy terryjreedy

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@methane @terryjreedy @StanFromIreland