Skip to content

gh-146446: Miscellaneous improvements to iOS XCframework build script#146447

Merged
freakboy3742 merged 6 commits intopython:mainfrom
freakboy3742:apple-build-fixes
Mar 26, 2026
Merged

gh-146446: Miscellaneous improvements to iOS XCframework build script#146447
freakboy3742 merged 6 commits intopython:mainfrom
freakboy3742:apple-build-fixes

Conversation

@freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Mar 26, 2026

Three improvements to the Apple/iOS XCframework build script:

  1. Honor the target that is selected for a clean target unless it's specifically overridden
  2. Ensures a valid fallback value if --slow-ci or --fast-ci isn't specified to the test command
  3. Allows for the location of the cross-build folder to be customised. This makes it easier to maintain multiple versions of iOS.

@freakboy3742 freakboy3742 merged commit ca6dfa0 into python:main Mar 26, 2026
29 checks passed
@freakboy3742 freakboy3742 deleted the apple-build-fixes branch March 26, 2026 21:54
@miss-islington-app
Copy link

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 26, 2026
…script (pythonGH-146447)

Modifies the iOS build script so that the clean target is more selective about
what is cleaned, the test target has a valid fallback value for ci mode, and the
cross-build directory can be customised.
(cherry picked from commit ca6dfa0f31132c80aaad40855087c2d931dc2d0f)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 26, 2026

GH-146496 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 26, 2026
freakboy3742 added a commit that referenced this pull request Mar 26, 2026
… script (GH-146447) (#146496)

Modifies the iOS build script so that the clean target is more selective about
what is cleaned, the test target has a valid fallback value for ci mode, and the
cross-build directory can be customised.
(cherry picked from commit ca6dfa0)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants