gh-144942: Fix macOS dylib build by adding $(MODLIBS) and removing -undefined dy…#145186
Open
gourijain029-del wants to merge 1 commit intopython:mainfrom
Open
gh-144942: Fix macOS dylib build by adding $(MODLIBS) and removing -undefined dy…#145186gourijain029-del wants to merge 1 commit intopython:mainfrom
gourijain029-del wants to merge 1 commit intopython:mainfrom
Conversation
gourijain029-del
requested review from
AA-Turner,
emmatyping and
erlend-aasland
as code owners
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
StanFromIreland
changed the title
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
gourijain029-del
force-pushed
the
fix-macos-dylib-missing-modlibs
branch
2 times, most recently
from
eeb5f4f to
10eb5ad
Compare
…ing -undefined dynamic_lookup
gourijain029-del
force-pushed
the
fix-macos-dylib-missing-modlibs
branch
from
10eb5ad to
b76620c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
gh-144942: Add $(MODLIBS) to macOS dylib build and remove -undefined dynamic_lookup
PR Description
Summary
This PR fixes an issue where the macOS libpython.dylib was missing $(MODLIBS) in its link command. This caused modules built statically (e.g., via
Modules/Setup.local
) to have their symbols omitted from the dynamic library, leading to runtime failures.
Additionally, this PR removes -undefined dynamic_lookup from the dylib link command. This ensures that any missing symbols are caught at build-time rather than resulting in null pointer dereferences or silent failures at runtime.
Changes
Updated
Makefile.pre.in$(MODLIBS) when linking libpython$ (LDVERSION).dylib.
to include
Removed -undefined dynamic_lookup from the same link command to enforce symbol resolution at build-time.