gh-144748: Make PyErr_CheckSignals raise the exception scheduled by PyThreadState_SetAsyncExc#145178
Open
encukou wants to merge 7 commits intopython:mainfrom
Open
gh-144748: Make PyErr_CheckSignals raise the exception scheduled by PyThreadState_SetAsyncExc#145178encukou wants to merge 7 commits intopython:mainfrom
encukou wants to merge 7 commits intopython:mainfrom
Conversation
encukou
requested review from
a team,
AA-Turner,
ZeroIntensity,
emmatyping,
ericsnowcurrently and
erlend-aasland
as code owners
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
This looks pretty good. Some non-blocking comments/questions below.
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
encukou
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @encukou for commit 2293148 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145178%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tstate->async_exc#144748📚 Documentation preview 📚: https://cpython-previews--145178.org.readthedocs.build/