GH-144552: Clean up tail-call.yml CI
#144553
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,14 @@ | ||
| name: Tail calling interpreter | ||
| on: | ||
| pull_request: | ||
| paths: &paths | ||
| - '.github/workflows/tail-call.yml' | ||
| - 'Python/bytecodes.c' | ||
| - 'Python/ceval.c' | ||
| - 'Python/ceval_macros.h' | ||
| - 'Python/generated_cases.c.h' | ||
| push: | ||
| paths: *paths | ||
| workflow_dispatch: | ||
|
|
||
| permissions: | ||
|
|
@@ -25,117 +20,109 @@ concurrency: | |
|
|
||
| env: | ||
| FORCE_COLOR: 1 | ||
| LLVM_VERSION: 21 | ||
|
|
||
| jobs: | ||
| windows: | ||
| name: ${{ matrix.target }} | ||
| runs-on: ${{ matrix.runner }} | ||
| timeout-minutes: 90 | ||
|
Member
There was a problem hiding this comment. Do we need entire 90 mins here? Looking at https://github.com/python/cpython/actions/runs/21803290596, the jobs take under 15 mins? So setting this to 20 should be enough to cover occasional network flakiness while still catching the stuck state early enough. |
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - target: x86_64-pc-windows-msvc/msvc | ||
| architecture: x64 | ||
| runner: windows-2025-vs2026 | ||
| build_flags: "" | ||
| run_tests: true | ||
| - target: x86_64-pc-windows-msvc/msvc-free-threading | ||
| architecture: x64 | ||
| runner: windows-2025-vs2026 | ||
| build_flags: --disable-gil | ||
| run_tests: false | ||
|
Member
There was a problem hiding this comment. On Linux free-threading the tests are run. Shall we save CI resources there, too, or play safe here and run the tests? |
||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.11' | ||
| - name: Build | ||
| shell: pwsh | ||
| run: | | ||
| $env:PlatformToolset = "v145" | ||
| ./PCbuild/build.bat --tail-call-interp ${{ matrix.build_flags }} -c Release -p ${{ matrix.architecture }} | ||
| - name: Test | ||
| if: matrix.run_tests | ||
| shell: pwsh | ||
| run: | | ||
| ./PCbuild/rt.bat -p ${{ matrix.architecture }} -q --multiprocess 0 --timeout 4500 --verbose2 --verbose3 | ||
|
|
||
| macos: | ||
| name: ${{ matrix.target }} | ||
| runs-on: ${{ matrix.runner }} | ||
| timeout-minutes: 90 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - target: x86_64-apple-darwin/clang | ||
| runner: macos-15-intel | ||
| - target: aarch64-apple-darwin/clang | ||
| runner: macos-14 | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.11' | ||
| - name: Install dependencies | ||
| run: | | ||
| brew update | ||
| brew install llvm@${{ env.LLVM_VERSION }} | ||
| - name: Build | ||
| run: | | ||
| export SDKROOT="$(xcrun --show-sdk-path)" | ||
| export PATH="/usr/local/opt/llvm@${{ env.LLVM_VERSION }}/bin:$PATH" | ||
| export PATH="/opt/homebrew/opt/llvm@${{ env.LLVM_VERSION }}/bin:$PATH" | ||
| CC=clang-${{ env.LLVM_VERSION }} ./configure --with-tail-call-interp | ||
| make all --jobs 4 | ||
| - name: Test | ||
| run: | | ||
| ./python.exe -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3 | ||
|
|
||
| linux: | ||
| name: ${{ matrix.target }} | ||
| runs-on: ${{ matrix.runner }} | ||
| timeout-minutes: 90 | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - target: x86_64-unknown-linux-gnu/gcc | ||
| runner: ubuntu-24.04 | ||
| configure_flags: --with-pydebug | ||
| - target: x86_64-unknown-linux-gnu/gcc-free-threading | ||
| runner: ubuntu-24.04 | ||
| configure_flags: --disable-gil | ||
| - target: aarch64-unknown-linux-gnu/gcc | ||
| runner: ubuntu-24.04-arm | ||
| configure_flags: --with-pydebug | ||
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: '3.11' | ||
| - name: Build | ||
| run: | | ||
| sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)" ./llvm.sh ${{ env.LLVM_VERSION }} | ||
| export PATH="$(llvm-config-${{ env.LLVM_VERSION }} --bindir):$PATH" | ||
| CC=clang-${{ env.LLVM_VERSION }} ./configure --with-tail-call-interp ${{ matrix.configure_flags }} | ||
| make all --jobs 4 | ||
| - name: Test | ||
| run: | | ||
| ./python -m test --multiprocess 0 --timeout 4500 --verbose2 --verbose3 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.