gh-143927: Normalize all line endings (CR, CRLF, and LF) in configparser#143929
Open
sethmlarson wants to merge 1 commit intopython:mainfrom
Open
gh-143927: Normalize all line endings (CR, CRLF, and LF) in configparser#143929sethmlarson wants to merge 1 commit intopython:mainfrom
sethmlarson wants to merge 1 commit intopython:mainfrom
Conversation
sethmlarson
added
needs backport to 3.10
cmaloney
reviewed
Jan 17, 2026
| value) | ||
| if value is not None or not self._allow_no_value: | ||
| value = delimiter + str(value).replace('\n', '\n\t') | ||
| # Convert all possible line-endings into '\n\t' |
Contributor
There was a problem hiding this comment.
Not sure the exact underlying security issue. As is, I think this will break round tripping on Windows; Text I/O used by the open expects to encode/decode newlines in particular formats on Windows by default (https://github.com/sethmlarson/cpython/blob/2a122fd420f5b425fd39848a48f5eb196cee2aa7/Lib/configparser.py#L753). See #143428 (comment) for a recent related case + more background links.
In the open calls can we use newline="" potentially?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.