gh-142414: Remove singleton design pattern in Lib/concurrent/interpreters/_crossinterp.py. #142577
Conversation
…est_interpreter_pool"
…THgP-.rst Co-authored-by: Peter Bierma <[email protected]>
We don't need to make singleton picklabe based on the current tests.
note35
force-pushed
the
gh-142414-singleton-removal
branch
from
2b1d0f1 to
b128769
Compare
note35
force-pushed
the
gh-142414-singleton-removal
branch
from
c7cf990 to
f74dcf9
Compare
Misc/NEWS.d/next/Library/2025-12-10-15-27-58.gh-issue-142414.zTHgP-.rst
Outdated
Show resolved
Hide resolved
…THgP-.rst Co-authored-by: Victor Stinner <[email protected]>
Misc/NEWS.d/next/Library/2025-12-10-15-27-58.gh-issue-142414.zTHgP-.rst
Outdated
Show resolved
Hide resolved
…THgP-.rst Co-authored-by: Victor Stinner <[email protected]>
| except queues.QueueEmpty: | ||
| # GH-142414: reloading the _queues module makes get to raise | ||
| # queues.QueueEmpty instead of interpreters.QueueEmpty. | ||
| pass |
There was a problem hiding this comment.
I'd like for this to be in a separate PR with a better test case.
There was a problem hiding this comment.
The fix is needed otherwise ./python Lib/test/test_runpy.py will run forever.
If a better test case is needed, we can introduce it in the same PR.
I haven’t yet figured out how the combination test causes this in a single test, I’ll need some more time to figure out that.
There was a problem hiding this comment.
That doesn't seem related to this PR. Can you reproduce the same infinite loop on main?
There was a problem hiding this comment.
Yes, the main branch has no issue because there’s no unbound reload (unbound is directly declared in queues) before this fix. The loop happens along with this fix.
There was a problem hiding this comment.
I think twice.
The existing test suite should already provide sufficient coverage. Since test_interpreter_pool naturally fails with deadlock when the issue exists. So we don't need an additional dedicated test if the test modifications in the PR is considered a legitimate bug fix (not workarounds).
./python -m test test_interpreters test_concurrent_futures.test_interpreter_pool
1. Before this fix: test_interpreters failed
2. After this fix: test_concurrent_futures.test_interpreter_pool failed without this catch
3. After this fix with the catch: all passed
3 participants
Test with
./python -m test test_interpreters test_struct./python -m test test_interpreters test_concurrent_futures.test_interpreter_pool./python -m test test_interpreters test_structfails with: KeyError: concurrent.interpreters._queues.UNBOUND #142414