Skip to content

Conversation

@Krishna-web-hub
Copy link
Contributor

@Krishna-web-hub Krishna-web-hub commented Oct 24, 2025

gh-140281: Doc: Update free-threading how-to

Key changes:

  • Updates text on immortal objects from "expected to be addressed" to "Work to further reduce...".
  • Updates performance overhead text from "expected to be reduced" to "was reduced" and notes that further reduction "remains an active development goal".
  • A NEWS entry has been added.

@python-cla-bot
Copy link

python-cla-bot bot commented Oct 24, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir awaiting review labels Oct 24, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Oct 24, 2025
@picnixz picnixz changed the title Updating the free-threading doc of python version 3.14 fix #140281 gh-140281: update 3.14 previsions for the free-threaded build Oct 24, 2025
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colesbury Did you want to keep the information from the old 3.13 FT build here?

@colesbury
Copy link
Contributor

Thanks for bringing this up. I think this needs to be reworked a bit more and we should limit it to 3.14. I don't think we need to discuss 3.13.

  • Immortalization: It's just code constants: numeric and string literals and tuple literals of those constants. Plus sys.intern
  • Frame objects: Should no longer crash, but we should verify this
  • Iterators: Should no longer crash

@Krishna-web-hub Krishna-web-hub force-pushed the doc-fix-140281 branch 2 times, most recently from b28265c to 2614ffb Compare October 29, 2025 22:37
@Krishna-web-hub
Copy link
Contributor Author

Hi @colesbury, thanks for the specific feedback.
I've just pushed a new, clean commit that addresses all your points:

  • The documentation has been refocused on 3.14, and the outdated 3.13 comparisons have been removed.

  • I've corrected the "Immortalization" section to match your clarification (limited to code constants, literals, and sys.intern).

  • The warnings about "Frame objects" and "Iterators" crashing have also been removed.

@Krishna-web-hub
Copy link
Contributor Author

hello @colesbury ,
I have done the changes you said about you can see and if you need any more changes then please tell me.

@colesbury colesbury self-requested a review November 17, 2025 14:09
@colesbury
Copy link
Contributor

Thanks @Krishna-web-hub. I'll make a few further edits before I merge.

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two little nitpicks regarding clarity. I don't consider them blocking, so feel free to ignore them if you want to.

@colesbury colesbury enabled auto-merge (squash) December 2, 2025 05:48
@colesbury colesbury added the needs backport to 3.14 bugs and security fixes label Dec 2, 2025
@colesbury colesbury merged commit 2dc28eb into python:main Dec 2, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Dec 2, 2025
@miss-islington-app
Copy link

Thanks @Krishna-web-hub for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2025
…h-140566)

(cherry picked from commit 2dc28eb)

Co-authored-by: Krishna-web-hub <[email protected]>
Co-authored-by: Sam Gross <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2025

GH-142173 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 2, 2025
colesbury added a commit that referenced this pull request Dec 2, 2025
) (gh-142173)

(cherry picked from commit 2dc28eb)

Co-authored-by: Krishna-web-hub <[email protected]>
Co-authored-by: Sam Gross <[email protected]>
@Krishna-web-hub
Copy link
Contributor Author

Thanks @colesbury and @ZeroIntensity for reviewing and merging this PR.
I really appreciate the guidance! Happy to continue contributing.

@Krishna-web-hub Krishna-web-hub deleted the doc-fix-140281 branch December 2, 2025 06:23
@Rogdham
Copy link
Contributor

Rogdham commented Dec 2, 2025

Thank you @Krishna-web-hub! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news topic-free-threading

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants