Skip to content

gh-136355: Deprecate -b and -bb CLI flags in 3.15 #136363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-136355: Deprecate -b and -bb CLI flags in 3.15 #136363

wants to merge 4 commits into from
+27 −0

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 7, 2025 •
edited by github-actions bot
Loading

@sobolevn sobolevn requested review from vstinner, hugovk and malemburg July 7, 2025 09:33
@bedevere-app bedevere-app bot mentioned this pull request Jul 7, 2025
Open
StanFromIreland
StanFromIreland reviewed Jul 7, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to pending-removal-in-3.17.rst?

Also, -bb is not documented and must be unliked/escaped (I don't know what to call: !) to stop errors.

vstinner
vstinner reviewed Jul 7, 2025
View reviewed changes
malemburg
malemburg requested changes Jul 7, 2025
View reviewed changes
Copy link
Member

@malemburg malemburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the wording changes, this LGTM.

@bedevere-app
Copy link

bedevere-app bot commented Jul 7, 2025

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

malemburg
malemburg reviewed Jul 7, 2025
View reviewed changes
hugovk
hugovk reviewed Jul 7, 2025
View reviewed changes
vstinner
vstinner reviewed Aug 5, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR to not emit a deprecation warning and not schedule the flag removal?

Can you also deprecate PyConfig.bytes_warning member in the doc? https://docs.python.org/dev/c-api/init_config.html#c.PyConfig.bytes_warning

@sobolevn sobolevn requested a review from AA-Turner as a code owner September 10, 2025 15:50
vstinner
vstinner reviewed Sep 10, 2025
View reviewed changes
@sobolevn sobolevn requested a review from FFY00 as a code owner September 10, 2025 16:04
@sobolevn
Copy link
Member Author

sobolevn commented Sep 10, 2025 •
edited
Loading

Done! I addressed all feedback: now we no longer plan to remove -b and -bb, we will only be making them no-op. No warning is raised.

Please, take another look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@hugovk hugovk hugovk left review comments

@malemburg malemburg malemburg requested changes

@StanFromIreland StanFromIreland StanFromIreland left review comments

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sobolevn @vstinner @hugovk @malemburg @StanFromIreland