gh-124864: Extend smtplib documentation on ESMTP options format #132547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
ZeroIntensity
approved these changes
Apr 21, 2025
hugovk
changed the title
|
Thanks @codeZeilen for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2025
pythonGH-132547) (cherry picked from commit 5802799) Co-authored-by: Patrick R <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 16, 2025
pythonGH-132547) (cherry picked from commit 5802799) Co-authored-by: Patrick R <[email protected]>
|
GH-142796 is a backport of this pull request to the 3.14 branch. |
|
GH-142797 is a backport of this pull request to the 3.13 branch. |
hugovk
pushed a commit
that referenced
this pull request
Dec 16, 2025
…at (GH-132547) (#142796) Co-authored-by: Patrick R <[email protected]>
hugovk
pushed a commit
that referenced
this pull request
Dec 16, 2025
…at (GH-132547) (#142797) Co-authored-by: Patrick R <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes adds to the documentation that ESMTP options are to be passed as strings, even if the option is in key-value form.
📚 Documentation preview 📚: https://cpython-previews--132547.org.readthedocs.build/en/132547/library/smtplib.html#smtplib.SMTP.sendmail