gh-113148: Handle exceptions from threading.atexit functions #130594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please take a look. |
sergey-miryanov
commented
Feb 26, 2025
| @@ -1546,7 +1546,11 @@ def _shutdown(): | |||
| # Call registered threading atexit functions before threads are joined. | |||
| # Order is reversed, similar to atexit. | |||
| for atexit_call in reversed(_threading_atexits): | |||
| atexit_call() | |||
| try: | |||
There was a problem hiding this comment.
As we handle all exceptions there then test_atexit_after_shutdown fails. Maybe we should ignore specific exception from _register_atexit (that called from atexit handler)?
There was a problem hiding this comment.
OTOH _register_atexit is private, so we can change its behavior. I don't see that b61b818 relying on this particular exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented proposed solution. Just add try/except and call threading excepthook.