Skip to content

[3.13] gh-128657: fix _hashopenssl ref/data race (GH-128886) #129852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1,737 commits into from

Conversation

tom-pytel
Copy link
Contributor

@tom-pytel tom-pytel commented Feb 8, 2025

Fix a possible data and PY_EVP_MD refcount race in _hashopenssl.c in py_digest_by_name() under free-threading.

miss-islington and others added 30 commits December 6, 2024 09:17
…n for ‘Y’ in datetime.strptime patterns (pythonGH-127590) pythonGH-127650)

pythongh-127552: Remove comment questioning 4-digit restriction for ‘Y’ in datetime.strptime patterns (pythonGH-127590)

The code has required 4 digits for the year since its inclusion in the stdlib in 2002 (over 22 years ago as of this commit).
(cherry picked from commit 51cfa56)

Co-authored-by: Beomsoo Kim <[email protected]>
…n#127703)

Fix typo in `Lib/_android_support.py` (pythonGH-127699)
(cherry picked from commit e59caf6)

Co-authored-by: Stan Ulbrych <[email protected]>
…ython#127721)

Give `poplib.POP3.rpop` a proper docstring (pythonGH-127370)

Previously `poplib.POP3.rpop` had a "Not sure what this does" docstring, now it has been fixed.
(cherry picked from commit 27d0d21)

Co-authored-by: Stan Ulbrych <[email protected]>
…wordMgrWithPriorAuth.__init__` (pythonGH-127735) (python#127744)

pythongh-127734: improve signature of `urllib.request.HTTPPasswordMgrWithPriorAuth.__init__` (pythonGH-127735)

improve signature of urllib.request.HTTPPasswordMgrWithPriorAuth.__init__
(cherry picked from commit a03efb5)

Co-authored-by: Stephen Morton <[email protected]>
…honGH-127592) (python#127754)

Adds a `use_system_log` config item to enable stdout/stderr redirection for
Apple platforms. This log streaming is then used by a new iOS test runner
script, allowing the display of test suite output at runtime. The iOS test
runner script can be used by any Python project, not just the CPython test
suite.
(cherry picked from commit 2041a95)
…e-entrency safe (pythonGH-126776) (python#127778)

pythongh-126775: make linecache.checkcache threadsafe and GC re-entrency safe (pythonGH-126776)

(cherry picked from commit 2233c30)

Co-authored-by: Thomas Grainger <[email protected]>
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Bartosz Sławecki <[email protected]>
…thon#127799)

Docs: Fix indents in `xmlrpc.client.rst` (pythonGH-127782)
(cherry picked from commit 035f512)

Co-authored-by: Yuki Kobayashi <[email protected]>
…ger feature. (pythonGH-127755) (python#127806)

Add versionadded annotation to use_system_logger feature.
(cherry picked from commit 5121685)

Co-authored-by: Russell Keith-Magee <[email protected]>
…ythonGH-127568) (pythonGH-127798)

This fixes a UBSan failure (unaligned zero-size memcpy) in `dictobject.c`.
(cherry picked from commit 9af96f4)

Co-authored-by: Bénédikt Tran <[email protected]>
…127772) (python#127815)

Add `extern "C"` around `PyTraceMalloc_` functions. (pythonGH-127772)

Pretty much everything else exported by Python.h has an extern "C"
annotation, yet this header appears to be missing one.
(cherry picked from commit 2cdeb61)

Co-authored-by: Peter Hawkins <[email protected]>
…ythonGH-127793) (python#127819)

* Fix merge conflicts.

* [3.13] pythongh-127791: Fix, document, and test `PyUnstable_AtExit` (pythonGH-127793)
(cherry picked from commit d5d84c3)

Co-authored-by: Peter Bierma <[email protected]>
…FC 850 date format (pythonGH-123405) (python#127828)

pythongh-123401: Fix http.cookies module to support obsolete RFC 850 date format (pythonGH-123405)
(cherry picked from commit 359389e)

Co-authored-by: Nano <[email protected]>
Co-authored-by: Wulian <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
…GH-127720) (python#127831)

pythongh-118915: C API: Document frame locals proxies. (pythonGH-127720)
(cherry picked from commit dd9da73)

Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
…127361) (pythonGH-127812)

pythongh-127257: ssl: Raise OSError for ERR_LIB_SYS (pythonGH-127361)

From the ERR_raise manpage:

    ERR_LIB_SYS

        This "library code" indicates that a system error is
        being reported.  In this case, the reason code given
        to `ERR_raise()` and `ERR_raise_data()` *must* be
        `errno(3)`.

This PR only handles ERR_LIB_SYS for the high-lever error types
SSL_ERROR_SYSCALL and SSL_ERROR_SSL, i.e., not the ones where
OpenSSL indicates it has some more information about the issue.
(cherry picked from commit f4b31ed)

Co-authored-by: Petr Viktorin <[email protected]>
… field (pythonGH-126938) (pythonGH-127825)

This backports the *test* from pythonGH-126938, with changed limit and exception class.

Co-authored-by: Melissa0x1f992 <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
…local support (pythonGH-127866) (pythonGH-127882)

This PR fixes the build issue introduced by the commit 628f6eb from
pythonGH-112207 on systems without thread local support.
(cherry picked from commit f823910)

Co-authored-by: velemas <[email protected]>
)

Fix typos in `Lib/_pydecimal.py` (pythonGH-127700)
(cherry picked from commit ed037d2)

Co-authored-by: Stan Ulbrych <[email protected]>
…ythonGH-127846) (python#127892)

Uses symlinks to install iOS framework into testbed clone, adds a verbose mode
to the iOS runner to hide most Xcode output, adds another mechanism to disable
terminal colors, and ensures that stdout is flushed after every write.
(cherry picked from commit ba2d2fd)

Co-authored-by: Russell Keith-Magee <[email protected]>
Document PyObject_SelfIter (pythonGH-127861)
(cherry picked from commit 58942a0)

Co-authored-by: Miro Hrončok <[email protected]>
…27857) (python#127900)

link to the correct output method in documentation (pythonGH-127857)
(cherry picked from commit 11ff328)

Co-authored-by: Viktor Kálmán <[email protected]>
…r_ handling (pythonGH-127872) (python#127917)

pythongh-127870: Detect recursive calls in ctypes _as_parameter_ handling (pythonGH-127872)
(cherry picked from commit 6ff38fc)

Co-authored-by: Victor Stinner <[email protected]>
@ZeroIntensity
Copy link
Member

I think you meant to target this towards the 3.13 branch, not main. I'm going to close this because every single codeowner will have a ping in their inbox for anything that happens here. Please reopen for 3.13!

@tom-pytel
Copy link
Contributor Author

I think you meant to target this towards the 3.13 branch, not main. I'm going to close this because every single codeowner will have a ping in their inbox for anything that happens here. Please reopen for 3.13!

🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.