gh-128657: Run test_hashlib with --parallel-threads
#129833
Merged
+20
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This catches the race in `py_digest_by_name` that is fixed separately in pythongh-128886.
|
cc @tom-pytel |
|
So the test triggers TSAN but still succeeds. I am guessing the TSAN error output triggers github action to fail? Would it make sense to catpure stderr (in general for tsan tests) so that the tests can fail directly? |
|
The test failed (as expected) before your commit: https://github.com/python/cpython/actions/runs/13209357165/job/36879773663 And now passes (as expected) after your PR was merged (and I merged main back into this PR): https://github.com/python/cpython/actions/runs/13217166856/job/36897772901 |
You are right, command line difference, adding the "-j4" switch makes it fail for me locally as well, without it it succeeds. |
gpshead
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This catches the race in
py_digest_by_namethat is fixed separately in gh-128886.