gh-128317: Move CLI calendar highlighting to private class #129625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encukou
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
Thank you for doing this!
I'm not sure what the next step should be -- perhaps the API should be improved to make this kind of customization easier; perhaps CLICalendar should be public. But, in plain text, avoiding terminal sequences is the right thing to do.
Misc/NEWS.d/next/Library/2025-02-03-22-31-43.gh-issue-128317.n2Swnh.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Petr Viktorin <[email protected]>
|
And thanks for the review! Re: next steps, I'm not planning on further changes to the calendar right now, although if the week numbering idea progresses, we can consider things like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following @encukou's suggestions in #128317 (comment).
I've added a
NEWSfile because #128318 went out in 3.14a4, so I think this warrants one?📚 Documentation preview 📚: https://cpython-previews--129625.org.readthedocs.build/