GH-128682: Make PyStackRef_CLOSE escaping.#129404
Merged
markshannon merged 9 commits intopython:mainfrom Feb 3, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
PyStackRef_CLOSEescaping.PyStackRef_CLOSEkills the variable, and then escapes.This PR adds an
EscapingCalldataclass to the analysis, with a newkillattribute.PyStackRef_CLOSEandPyStackRef_XCLOSEset thekillattribute, so the code generator knows to kill the argument before spilling.Doing so, means that
pop_N_errorlabels no longer work as we need to adjust the stack pointer before allPyStackRef_CLOSErather than once at the jump to error.Performance numbers to come...