Skip to content

gh-128690: temporarily do not use test_embed in PGO profile builds #128771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

ned-deily
Copy link
Member

@ned-deily ned-deily commented Jan 13, 2025

As documented in #128690, under certain configurations test case test_init_pyvenv_cfg of test_embed fails apparently since 34e840f. This behavior was not seen in 3.14.0a3, the most recent alpha before this change. Unfortunately, test_embed is included in the subset of tests used for PGO profile builds when Python is built with --enable-optimizations. If any of the tests included in the PGO profile build fails, including test_embed, the whole Python build fails. Besides the originally reported case, I have now seen this failure in two other macOS build configurations, both rather complex; one is for the build of the python.org installer package. (At the moment, I haven't had time to produce a manageable reproducible test case.) It could be that this is just an existing test case issue that was brought to the fore by the above change. Since the failure involves sys._base_executable, it's possible that the behavior documented in #128670 might be the root cause.

If necessary for 3.14.0a4, I could apply this PR manually to avoid using test_embed in the profile builds. But I would prefer to either have the test failure resolved prior to a4 or merge this PR to temporarily avoid using test_embed. Marking as release-blocker for release manager decision.

cc: @hugovk @FFY00

@ned-deily ned-deily added release-blocker 3.14 new features, bugs and security fixes labels Jan 13, 2025
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this for a4, especially if it's temporary, and I guess it won't make too much difference to the PGO build.

@ned-deily ned-deily merged commit b00e125 into python:main Jan 13, 2025
56 checks passed
@ned-deily ned-deily deleted the gh-128690-test_embed-pgo branch January 13, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.14 new features, bugs and security fixes release-blocker
Projects
Development

Successfully merging this pull request may close these issues.

2 participants