gh-128690: temporarily do not use test_embed in PGO profile builds #128771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented in #128690, under certain configurations test case
test_init_pyvenv_cfg
oftest_embed
fails apparently since 34e840f. This behavior was not seen in 3.14.0a3, the most recent alpha before this change. Unfortunately,test_embed
is included in the subset of tests used for PGO profile builds when Python is built with--enable-optimizations
. If any of the tests included in the PGO profile build fails, includingtest_embed
, the whole Python build fails. Besides the originally reported case, I have now seen this failure in two other macOS build configurations, both rather complex; one is for the build of the python.org installer package. (At the moment, I haven't had time to produce a manageable reproducible test case.) It could be that this is just an existing test case issue that was brought to the fore by the above change. Since the failure involves sys._base_executable, it's possible that the behavior documented in #128670 might be the root cause.If necessary for 3.14.0a4, I could apply this PR manually to avoid using
test_embed
in the profile builds. But I would prefer to either have the test failure resolved prior to a4 or merge this PR to temporarily avoid usingtest_embed
. Marking asrelease-blocker
for release manager decision.cc: @hugovk @FFY00
test_embed.test_init_pyvenv_cfg()
fails #128690