gh-128639: Don't assume one thread in subinterpreter finalization #128640
+100
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroIntensity
commented
Jan 8, 2025
| Py_NewInterpreter(); | ||
| Py_NewInterpreter(); | ||
| Py_NewInterpreter(); | ||
| PyThreadState *tstate = PyThreadState_Get(); |
There was a problem hiding this comment.
I think this test working before was a fluke. Py_NewInterpreter changes the thread state, and I don't think we support calling Py_Finalize from a subinterpreter.
| if (tstate == NULL) | ||
| { | ||
| // XXX Some graceful way to always get a thread state? | ||
| Py_FatalError("thread state allocation failed"); |
There was a problem hiding this comment.
Should you stop and return after this?
There was a problem hiding this comment.
No, there's no way to fail here other than a fatal error.
There was a problem hiding this comment.
Oh, I see now that Py_FatalError aborts execution.
…rpreter-thread-shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incidentally, this also fixed the warning not showing up if a subinterpreter wasn't cleaned up via
_interpreters.destroy. I had to update some of the tests as a result.