Skip to content

GH-121970: Modernise the patchlevel extension #121995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 20, 2024
Merged

GH-121970: Modernise the patchlevel extension #121995

merged 4 commits into from
Jul 20, 2024
+62 −54

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Jul 18, 2024 •
edited
Loading

  • Remove print_function future
  • Use a standard version_info interface
  • Use absolute paths to find patchlevel.h

Note: patchlevel isn't really an extension. Ideally we would make it into one, but there are several uses of version and release in conf.py, so we probably can't at the moment.

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news labels Jul 18, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 18, 2024
Open
@AA-Turner AA-Turner changed the title GH-121970: Modernise patchlevel GH-121970: Modernise the patchlevel extension Jul 18, 2024
@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jul 19, 2024
@AA-Turner AA-Turner enabled auto-merge (squash) July 20, 2024 13:33
@AA-Turner AA-Turner merged commit b7ad711 into python:main Jul 20, 2024
24 checks passed
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2024
@AA-Turner @miss-islington
pythonGH-121970: Modernise the patchlevel extension (pythonGH-121995)
b16f4d7 
(cherry picked from commit b7ad711)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jul 20, 2024

GH-122060 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 20, 2024
@AA-Turner @miss-islington
pythonGH-121970: Modernise the patchlevel extension (pythonGH-121995)
f0bebb3 
(cherry picked from commit b7ad711)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 20, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 20, 2024

GH-122061 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jul 20, 2024
AA-Turner added a commit that referenced this pull request Jul 20, 2024
@miss-islington @AA-Turner
[3.12] GH-121970: Modernise the patchlevel extension (GH-121995) (#12…
ca531e4 
…2061)

GH-121970: Modernise the patchlevel extension (GH-121995)
(cherry picked from commit b7ad711)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Jul 20, 2024
@miss-islington @AA-Turner
[3.13] GH-121970: Modernise the patchlevel extension (GH-121995) (#12…
efc7d1c 
…2060)

GH-121970: Modernise the patchlevel extension (GH-121995)
(cherry picked from commit b7ad711)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AA-Turner