[3.13] gh-117398: Use the correct module loader for iOS in datetime CAPI test (GH-120477) #121561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@freakboy3742 Could you review the backport? I failed to trigger the iOS build bot. |
|
!buildbot iOS |
freakboy3742
approved these changes
Jul 10, 2024
|
@neonene Thanks for the backport (and nice work hunting down the fix without access to the buildbot!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#119604 added a CAPI test for subinterpreters in the datetime tests; however, the test uses the ExtensionFileLoader to load
_testcapi. iOS requires the use of the AppleFrameworkLoader.(backported from commit 5c58e72, AKA gh-120477)