Skip to content

gh-119819: Conditional skip of logging tests that require multiprocessing subprocess support #120476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2024
Merged

gh-119819: Conditional skip of logging tests that require multiprocessing subprocess support #120476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Lib/test/test_logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3898,6 +3898,7 @@ def do_queuehandler_configuration(self, qspec, lspec):
self.addCleanup(os.remove, fn)

@threading_helper.requires_working_threading()
@support.requires_subprocess()
def test_config_queue_handler(self):
q = CustomQueue()
dq = {
Expand Down Expand Up @@ -3926,12 +3927,10 @@ def test_config_queue_handler(self):
msg = str(ctx.exception)
self.assertEqual(msg, "Unable to configure handler 'ah'")

@support.requires_subprocess()
def test_multiprocessing_queues(self):
# See gh-119819

# will skip test if it's not available
import_helper.import_module('_multiprocessing')

cd = copy.deepcopy(self.config_queue_handler)
from multiprocessing import Queue as MQ, Manager as MM
q1 = MQ() # this can't be pickled
Expand Down
Loading