Skip to content

gh-117398: Move types to datetime state #118606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 5, 2024

Move types to the datetime_state structure of the _datetime extension.

@vstinner
Copy link
Member Author

vstinner commented May 7, 2024

cc @erlend-aasland @neonene

I marked the PR as a draft until the main branch becomes Python 3.14.

@vstinner vstinner marked this pull request as ready for review May 8, 2024 16:40
@vstinner vstinner requested review from pganssle and abalkin as code owners May 8, 2024 16:40
@vstinner
Copy link
Member Author

vstinner commented May 8, 2024

The main branch is now Python 3.14. I mark the PR as ready for review.

@erlend-aasland @corona10: Do you want to review it?

Move types to the datetime_state structure of the _datetime
extension.
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense as a first step!

@vstinner vstinner merged commit a895756 into python:main May 10, 2024
36 checks passed
@vstinner vstinner deleted the datetime_state branch May 10, 2024 13:24
ericsnowcurrently pushed a commit to ericsnowcurrently/cpython that referenced this pull request May 28, 2024
Move types to the datetime_state structure of the _datetime
extension.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants