gh-117657: Quiet TSAN warnings about remaining non-atomic accesses of tstate->state
#118165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate` These should be the last instances of TSAN warning of data races when accessing `tstate->state` non-atomically. TSAN reports a race between accessing `tstate->state` in `_PyThreadState_Suspend()` and the compare/exhange in `park_detached_threads`. This is a false positive due to TSAN modeling failed compare/exchange operations as writes. TSAN reports a race between accessing `tstate->state` in `_PySemaphore_Wait()` and the compare/exchange in `park_detached_threads`. This is the same issue that we saw in pythongh-117830.
mpage
changed the title
tstate->statetstate->state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should be the last instances of TSAN warning of data races when accessing
tstate->statenon-atomically.TSAN reports a race (example) between accessing
tstate->statein_PyThreadState_Suspend():cpython/Python/pystate.c
Line 2099 in fc21c7f
and the compare/exchange in
park_detached_threads():cpython/Python/pystate.c
Lines 2172 to 2173 in fc21c7f
This is a false positive due to TSAN modeling failed compare/exchange operations as writes.
TSAN also reports a race (example) between accessing
tstate->statein_PySemaphore_Wait():cpython/Python/parking_lot.c
Line 197 in fc21c7f
and the compare/exchange in
park_detached_threads()above. This is the same issue that we saw in gh-117830.