Clarifying nonlocal doc: SyntaxError is raised if nearest enclosing scope is global #114009
Conversation
bedevere-app
bot
added
docs
serhiy-storchaka
requested review from
JelleZijlstra,
AA-Turner,
CAM-Gerlach and
AlexWaygood
Doc/reference/executionmodel.rst
Outdated
| specified in the statement refer to the bindings of those names in the top-level | ||
| namespace. Names are resolved in the top-level namespace by searching the | ||
| global namespace, i.e. the namespace of the module containing the code block, | ||
| global namespace, the namespace of the module containing the code block, |
There was a problem hiding this comment.
Removing "i.e." makes this wrong: the global namespace is the same as the module namespace here.
There was a problem hiding this comment.
That's what I am implying here. The next part of the sentence is written in the same way.
"the builtins namespace, the namespace of the module builtins" implying the builtins namespace and the namespace of the module builtins are the same.
There was a problem hiding this comment.
I see; I don't think that is clear on reading the sentence.
There was a problem hiding this comment.
How about this version of the sentence?
"Names are resolved in the top-level namespace by searching the global namespace which is the namespace of the module containing the code block, and the builtins namespace which is the namespace of the module builtins."
Doc also uses the word "module namespace" frequently.
There was a problem hiding this comment.
That works though I'd put commas before "which". I think the existing wording is fine though, so I'd prefer to keep it.
There was a problem hiding this comment.
Reverted it.
I think, both of us needing a secondary clarification is a sign that this sentence could be written better.
JelleZijlstra
added
needs backport to 3.11
|
Thanks @quazi-irfan for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…cope is global (pythonGH-114009) (cherry picked from commit 1558d99) Co-authored-by: Quazi Irfan <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]>
|
GH-118128 is a backport of this pull request to the 3.12 branch. |
…osing scope is global (GH-114009) (#118128) Clarifying nonlocal doc: SyntaxError is raised if nearest enclosing scope is global (GH-114009) (cherry picked from commit 1558d99) Co-authored-by: Quazi Irfan <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]>
(Made a new PR because force push messed up the original PR #113572)
N̶o̶n̶l̶o̶c̶a̶l̶ ̶t̶h̶r̶o̶w̶s̶ ̶S̶y̶n̶t̶a̶x̶E̶r̶r̶o̶r̶ ̶i̶f̶ ̶t̶h̶e̶ ̶n̶e̶a̶r̶e̶s̶t̶ ̶e̶n̶c̶l̶o̶s̶i̶n̶g̶ ̶s̶c̶o̶p̶e̶ ̶i̶s̶ ̶g̶l̶o̶b̶a̶l̶.̶ ̶C̶u̶r̶r̶e̶n̶t̶l̶y̶,̶ ̶P̶y̶t̶h̶o̶n̶ ̶L̶a̶n̶g̶u̶a̶g̶e̶ R̶e̶f̶e̶r̶e̶n̶c̶e̶ ̶s̶e̶c̶t̶i̶o̶n̶ ̶E̶x̶e̶c̶u̶t̶i̶o̶n̶ ̶M̶o̶d̶e̶l̶ ̶4̶.̶2̶.̶2̶ ̶d̶o̶e̶s̶ ̶n̶o̶t̶ ̶s̶a̶y̶ ̶s̶o̶.̶ This pull request fixes that. This PR also adds another statement, in the same section, saying
globalstatement creates a variable if existing variable binding is not found.Here is the link to Python Docs discord discussion thread with @ezio-melotti on this topic.
https://docs.python.org/3/reference/executionmodel.html#resolution-of-names
📚 Documentation preview 📚: https://cpython-previews--114009.org.readthedocs.build/