Skip to content

Do not use deprecated logger.warn() in pyspecific #107694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Aug 6, 2023

I noticed whilst working on #19470 that pyspecific still uses .warn() methods.

A


📚 Documentation preview 📚: https://cpython-previews--107694.org.readthedocs.build/

@AA-Turner AA-Turner added docs Documentation in the Doc dir skip issue skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 6, 2023
@AA-Turner AA-Turner requested a review from hugovk August 6, 2023 13:48
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@AA-Turner
Copy link
Member Author

Thanks Alex!

A

@AlexWaygood AlexWaygood merged commit 9564e31 into python:main Aug 6, 2023
@miss-islington
Copy link
Contributor

Thanks @AA-Turner for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-107695 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 6, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2023
(cherry picked from commit 9564e31)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-bot
Copy link

GH-107696 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 6, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2023
(cherry picked from commit 9564e31)

Co-authored-by: Adam Turner <[email protected]>
AlexWaygood pushed a commit that referenced this pull request Aug 6, 2023
…) (#107696)

Do not use deprecated ``logger.warn()`` in pyspecific (GH-107694)
(cherry picked from commit 9564e31)

Co-authored-by: Adam Turner <[email protected]>
Yhg1s pushed a commit that referenced this pull request Aug 6, 2023
…) (#107695)

Do not use deprecated ``logger.warn()`` in pyspecific (GH-107694)
(cherry picked from commit 9564e31)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants