-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to stdout isatty for colour detection instead of stderr #128595
Comments
hugovk
added a commit
that referenced
this issue
Jan 13, 2025
Co-authored-by: Erlend E. Aasland <[email protected]>
hugovk
added a commit
to hugovk/cpython
that referenced
this issue
Jan 13, 2025
…lour (pythonGH-128687) (cherry picked from commit afb9dc8) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Erlend E. Aasland <[email protected]>
hugovk
added a commit
that referenced
this issue
Jan 13, 2025
…H-128687) (#128778) Co-authored-by: Erlend E. Aasland <[email protected]>
hugovk
added a commit
that referenced
this issue
Jan 20, 2025
…tderr (#128498) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
hugovk
added a commit
to hugovk/cpython
that referenced
this issue
Jan 20, 2025
… instead of stderr (pythonGH-128498) (cherry picked from commit 6f167d7) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
hugovk
added a commit
to hugovk/cpython
that referenced
this issue
Jan 20, 2025
… instead of stderr (pythonGH-128498) (cherry picked from commit 6f167d7) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
This was referenced Jan 20, 2025
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this issue
Jan 21, 2025
…d of stderr (python#128498) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Victor Stinner <[email protected]>
hugovk
added a commit
that referenced
this issue
Jan 21, 2025
hugovk
added a commit
to hugovk/cpython
that referenced
this issue
Jan 21, 2025
…le' on buildbots (python#129070)
hugovk
added a commit
that referenced
this issue
Jan 21, 2025
…ad of stderr (GH-128498) (#129057) Co-authored-by: Hugo van Kemenade <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Victor Stinner <[email protected]> Fix `test__colorize` unexpected keyword argument 'file' on buildbots (#129070)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Bug description:
The terminal colour detection defaults to checking
stderr
'sisatty
, rather thanstdout
.As suggested at #128317 (comment), let's default to checking
stdout
'sisatty
rather thanstderr
's.Here some example output, plus when piping it:
CPython versions tested on:
3.13, CPython main branch
Operating systems tested on:
macOS
Linked PRs
test__colorize
unexpected keyword argument 'file' on buildbots #129070The text was updated successfully, but these errors were encountered: