Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.14 #417

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Test Python 3.14 #417

wants to merge 4 commits into from

Conversation

ezio-melotti
Copy link
Member

Add 3.14, just like 3.13 was added in:

@ezio-melotti ezio-melotti marked this pull request as draft March 2, 2025 03:10
@ezio-melotti
Copy link
Member Author

These are the same failures seen in:

@AA-Turner
Copy link
Member

For the deprecation warning, we could add an exclusion to the pytest configuration, I believe?

A

@hugovk
Copy link
Member

hugovk commented Mar 2, 2025

Yes, the upstreams already know about it, let's update pytest.ini to something like this:

filterwarnings =
    error
    ignore:'asyncio.get_event_loop_policy' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio
    ignore:'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction.. instead:DeprecationWarning:aiohttp
    ignore:'asyncio.set_event_loop' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio
    ignore:'asyncio.set_event_loop_policy' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@hugovk
Copy link
Member

hugovk commented Apr 6, 2025

Thanks for the ping, CLA Bot the Second.

Yes, the upstreams already know about it, let's update pytest.ini to something like this:

filterwarnings =
    error
    ignore:'asyncio.get_event_loop_policy' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio
    ignore:'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction.. instead:DeprecationWarning:aiohttp
    ignore:'asyncio.set_event_loop' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio
    ignore:'asyncio.set_event_loop_policy' is deprecated and slated for removal in Python 3.16:DeprecationWarning:pytest_asyncio

Updated and CI is now green.

@hugovk hugovk marked this pull request as ready for review April 6, 2025 17:01
@ezio-melotti
Copy link
Member Author

Hmm, the failure were the same as:

but that was closed in favor of:

which had no failures.

Around the same time, @dependabot also created a PR for this repo:

After merging it, I updated this branch hoping that the failures would disappear, as it happened for bedevere, but they didn't.

Upon further investigation, I noticed that some packages haven't been updated:

aiohttp==3.11.13
aiohttp-jinja2==1.6
gidgethub==5.3.0
aiohttp-session[secure]==2.12.1
sentry-sdk==2.25.0

python/bedevere#662 updated aiohttp to 3.11.15, which might have fixed the warnings, but that update wasn't included in #418.

The changelog for the releases (3.11.14/15) don't mention anything about the deprecation, but there is now a new release (3.11.16) that includes:

Replaced deprecated asyncio.iscoroutinefunction with its counterpart from inspect

We should be able to remove the filters and update aiohttp to 3.11.16 manually to fix the warnings and add 3.14.


I was also wondering why the updated wasn't included in #418. Turns out that on April 1st:

This explains why 3.11.15 wasn't included in #418, but 3.11.14 was released 3 weeks ago and should have been included. Maybe @dependabot wanted to prank us creating PRs at 4:04AM with a dependency not found on April 1st?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants