-
-
Notifications
You must be signed in to change notification settings - Fork 378
Bump dependencies from commit 4f905c #3374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull request was closed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3374 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 128 128
Lines 19414 19414
Branches 1318 1318
===============================================
Hits 19414 19414 🚀 New features to boost your workflow:
|
|
Looks like mypy errors from sphinx sphinx-doc/sphinx#14153 being merged, because of using new |
|
Probably we pass python-version as 3.11 and it checks using that... |
| commands = | ||
| pre-commit run pip-compile --all-files | ||
|
|
||
| # TODO: allow specifying e.g. typing-3.11 to run with --python[-]version=3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this about what we pass to mypy? Or to pip install? Because we configure mypy in https://github.com/python-trio/trio/blob/main/pyproject.toml#L191 (oops, just realized we use 3.10 not 3.11).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably about passing different python version and platform args to MyPy, IIRC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, well that doesn't seem excessively helpful (it rhymes with a goal I've had of having mypy check all python versions, but I think there are more effective ways than copying and pasting a given tox config section... and anyways the TODO probably isn't that helpful in getting this.)
No description provided.