Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 1, 2026

No description provided.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 1, 2026
@github-actions github-actions bot enabled auto-merge (squash) January 1, 2026 00:06
@A5rocks A5rocks closed this Jan 1, 2026
auto-merge was automatically disabled January 1, 2026 00:09

Pull request was closed

@A5rocks A5rocks reopened this Jan 1, 2026
@A5rocks A5rocks enabled auto-merge (squash) January 1, 2026 00:09
@codecov
Copy link

codecov bot commented Jan 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (4f905c2) to head (cb6067f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@               Coverage Diff               @@
##                 main        #3374   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             128          128           
  Lines           19414        19414           
  Branches         1318         1318           
===============================================
  Hits            19414        19414           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@CoolCat467
Copy link
Member

Looks like mypy errors from sphinx sphinx-doc/sphinx#14153 being merged, because of using new type keyword, but not sure why that error is being raised since the mypy CI runner is using python 3.13.

@A5rocks
Copy link
Contributor

A5rocks commented Jan 1, 2026

Probably we pass python-version as 3.11 and it checks using that...

commands =
pre-commit run pip-compile --all-files

# TODO: allow specifying e.g. typing-3.11 to run with --python[-]version=3.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakkdl or @webknjaz: I don't think I understood what this is about. (I don't really know much about tox :/)

I assume this change doesn't fix it, but I can't really visualize what fixing this looks like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this about what we pass to mypy? Or to pip install? Because we configure mypy in https://github.com/python-trio/trio/blob/main/pyproject.toml#L191 (oops, just realized we use 3.10 not 3.11).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably about passing different python version and platform args to MyPy, IIRC.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, well that doesn't seem excessively helpful (it rhymes with a goal I've had of having mypy check all python versions, but I think there are more effective ways than copying and pasting a given tox config section... and anyways the TODO probably isn't that helpful in getting this.)

@A5rocks A5rocks disabled auto-merge January 4, 2026 20:04
@A5rocks A5rocks merged commit fc8c199 into main Jan 5, 2026
44 checks passed
@A5rocks A5rocks deleted the autodeps/bump_from_4f905c branch January 5, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants