-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reason for failed match to RaisesGroup #3145
Open
jakkdl
wants to merge
22
commits into
python-trio:main
Choose a base branch
from
jakkdl:raisesgroup_fail_reason
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,047
−119
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
03a3959
RaisesGroup will now raise an assertionerror with an informative mess…
jakkdl c0dcb58
suggest allow_unwrapped if it would match with it
jakkdl 2b98b2f
fix test fails
jakkdl f84d9d1
codecov and fix suggestion to re.escape string
jakkdl df27595
add _check_expected helper
jakkdl 993a173
remove trailing period. Add trying_flattening and suggest_flattening.…
jakkdl 656e040
simplify & remove false positive for suggestion to use flatten_subgroups
jakkdl debe557
overhaul message in the complicated case. Avoid printing check repr i…
jakkdl a8e263c
Merge remote-tracking branch 'origin/main' into raisesgroup_fail_reason
jakkdl 8281d7c
Merge branch 'main' into raisesgroup_fail_reason
jakkdl 3f757f1
Merge remote-tracking branch 'origin/main' into raisesgroup_fail_reason
jakkdl a62a252
add fails_raises_group test helper
jakkdl 5efafd5
parenthesized-with
jakkdl 6ab9ac9
add newsfragment
jakkdl f38d63b
print type(e).__name__ instead of repr on type fail. Don't print repr…
jakkdl b6ce586
don't print brief error if there's a possibility of misordering
jakkdl ebbf694
Merge remote-tracking branch 'origin/main' into raisesgroup_fail_reason
jakkdl 9748cc8
change message when encountering group and expecting a bare exception…
jakkdl 89bf77e
procrastinating on fixing expected-exception-matches-already-matched-…
jakkdl ba938bc
specify 'of [base]exceptiongroup when regex fails against the group; …
jakkdl 9612d1e
fix sphinx
jakkdl 580137d
overhaul saving of results. Print would-have-matched for expected wit…
jakkdl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
`trio.testing.RaisesGroup` now raises an `AssertionError` with a helpful message if it fails to match the raised exception. Previously it would let the original exception fall through, but that is now instead the ``__context__``. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -318,8 +318,11 @@ def lookup_symbol(symbol: str) -> dict[str, str]: | |
if module_name == "trio.socket" and class_name in dir(stdlib_socket): | ||
continue | ||
|
||
# ignore class that does dirty tricks | ||
if class_ is trio.testing.RaisesGroup: | ||
# Ignore classes that don't use attrs, they only define their members once | ||
# __init__ is called (and reason they don't use attrs is because they're going | ||
jakkdl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
# to be reimplemented in pytest). | ||
# I think that's why these are failing at least? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You could try tossing attrs on them and seeing! But I think so too. Maybe even just try putting |
||
if class_ is trio.testing.RaisesGroup or class_ is trio.testing.Matcher: | ||
continue | ||
|
||
# dir() and inspect.getmembers doesn't display properties from the metaclass | ||
|
@@ -460,11 +463,6 @@ def lookup_symbol(symbol: str) -> dict[str, str]: | |
"send_all_hook", | ||
"wait_send_all_might_not_block_hook", | ||
}, | ||
trio.testing.Matcher: { | ||
"exception_type", | ||
"match", | ||
"check", | ||
}, | ||
} | ||
if tool == "mypy" and class_ in EXTRAS: | ||
before = len(extra) | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be useful to say how to get back the raised exception here. Also maybe some sort of rewording to put "if it fails" earlier to avoid people thinking this effects them. But both of those are... unnecessary.